search

eclipse / xtext-lib

Eclipse Xtext™ Libraries
https://www.eclipse.org/Xtext/
Eclipse Public License 2.0
19 stars 33 forks source link

Move to Maven/Tycho for projects and build infrastructure #501

Closed LorenzoBettini closed 1 year ago

LorenzoBettini commented 1 year ago

Replaces https://github.com/eclipse/xtext-lib/pull/500

cdietrich commented 1 year ago

yes. the same as it would be a monorepo. the only place we use other version is xtend-maven-plugin. and it should be done with profile so that it can be decided if from sonatype or from upstream branches

LorenzoBettini commented 1 year ago

yes. the same as it would be a monorepo. the only place we use other version is xtend-maven-plugin. and it should be done with profile so that it can be decided if from sonatype or from upstream branches

I'm doing some experiments in xtext-core concerning the versioning across Git repositories.

So I introduced xtext-dev-bom-version that defaults to project.version and can be redefined in projects like xtext.logging that has a different version https://github.com/eclipse/xtext-core/commit/e329fc2f88c92fae965ec959e6bf9cd752d507c9

Besides that, I always use project.version for referring to xtext artifacts coming from other git repositories: https://github.com/eclipse/xtext-core/commit/31358b58febf2dcbd9245c28a1090090baaeec8c

During building, we use the profile useJenkinsSnapshots so the snapshots are found. But what about without that profile? For example, in Eclipse? Without snapshot repository specification, snapshots are not found. A profile for sonatype snapshots will not work because activeByDefault, as I said in the past, is not really active by default.

Thus, the sonatype snapshot repository is the default (specified outside profiles), and the profile useJenkinsSnapshots explicitly disables that sonatype snapshots repository: https://github.com/eclipse/xtext-core/commit/53f0781e16304cc81e9aeacfe24a1fd970253120

cdietrich commented 1 year ago

with the repo merge done this is obsolete