eclipseisoffline / jukeboxcustomdiscfix

This mod fixes bug MC-260346, which causes custom music discs, when played in a jukebox, to be cut off when the vanilla disc would normally end.
https://modrinth.com/mod/jukebox-custom-disc-fix
GNU Lesser General Public License v3.0
0 stars 0 forks source link

[BUG] <installed and loaded, but no effect> #5

Open Liink56 opened 1 month ago

Liink56 commented 1 month ago

I correctly installed the mod on my Aternos client and server, but the mod does not seem to have the desired effect (correct the length of the custom music added to the vanilla music on the discs).

To reproduce : 1-Install the mod on the forge loader in version 1.20.1, also install a resourcepack modifying the music of the vanilla discs to give them longer or shorter music than the originals.

2-Start your game with the mod load, then apply your resourcepack and start a single player game (or multiplayer if the mod is installed on the server in addition to the client).

3-Play music from an edit disc on the classic jukebox and wait for the music to finish.

4-If the disc continues to spin even though the music is finished, or if the music suddenly cuts off, then the bug is in effect.

The duration of the disc is supposed to be synchronized with the music played, regardless of its length.

Minecraft setup :

Logs : ( https://mclo.gs/QhL9wJ4 )

eclipseisoffline commented 1 month ago

3-Play music from an edit disc on the classic jukebox and wait for the music to finish.

Is the "classic jukebox" a modded block or the vanilla Jukebox block? If it is a modded block, from which mod is it?

Liink56 commented 1 month ago

I don't really know, because I use the vanilla jukebox, but a mod (amendment) modifies the appearance of the jukebox so that we see the record spinning (like a phonograph), maybe that's where it comes from.

eclipseisoffline commented 1 month ago

Could you try without the Amendments mod and confirm the issue still exists?

It's likely a mod compatibility issue since both this mod and the Amendments mod change the JukeboxBlockEntity class, but it might be hard to work around given the Amendments mod is licensed under ARR (All Rights Reserved).

If the issue doesn't exist without the Amendments mod I'll try to make this mod work with it, but I'm unsure if I'm able to.

Liink56 commented 1 month ago

I can confirm after testing that the problem persists even after removing the amendment mod (I compared with my sound processing software), so it must come from another mod, but I couldn't say which one, because I I only noticed an amendment that could impact the operation of the vanilla jukebox.

eclipseisoffline commented 1 month ago

Hm, alright. I'll try to reproduce with your mods later today to figure out what the issue is.