Open vincenzodetoma opened 4 months ago
This notebook has the same issues described in #152. Please revise the notebook and let me know when you upload the new version.
Hi @malmans2, sure, I'm following the template you provided. I removed the height and dpi keywords in the thumbnail picture cell. Checked also the reference and their citations, all seems ok to me. Is there anything else strange? I will review also the other two notebooks between today and maximum tomorrow/the day after. Thanks, I put also @andreastorto in cc so he can read. Vincenzo srb_q1.zip
Almost good, but some references are still wrong. You need to provide the url of the DOI, so it is "clickable". No worries though, I will fix it myself and provide permalink and preview. Just make sure you do the same for the other notebooks.
Also, I still see the warnings on top:
<div class="alert alert-block alert-warning">
Note, in this template the banner images, and Jupyter Book specific markdown are removed.
</div>
<div class="alert alert-block alert-warning">
Note: if the assessment does not include code (a literature review, paper or PQAR summary, etc), then this template can followed as a (.pynb) file, without any code cells and only embedded images.
</div>
It doesn't look like something you should include in your notebook, plus I don't see them in the template. Can I remove them?
Yes, for sure. Thanks! I will correct Also the other notebooks accordingly
Il giorno lun 29 lug 2024 alle 17:40 Mattia Almansi < @.***> ha scritto:
Also, I still see the warnings on top:
Note, in this template the banner images, and Jupyter Book specific markdown are removed.Note: if the assessment does not include code (a literature review, paper or PQAR summary, etc), then this template can followed as a (.pynb) file, without any code cells and only embedded images.It doesn't look like something you should include in your notebook, plus I don't see them in the template https://ecmwf-projects.github.io/c3s2-eqc-quality-assessment/templates/template.html. Can I remove them?
— Reply to this email directly, view it on GitHub https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/issues/154#issuecomment-2256267603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL5DLSJLFUISHO2NJQVQHGLZOZO57AVCNFSM6AAAAABLQRQJHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGI3DONRQGM . You are receiving this because you authored the thread.Message ID: @.*** com>
Please ensure that the notebook name is correct. If you need to make any modifications (e.g., addressing the reviewer's comments), please share the new version of the notebook here, and I will provide a new permalink. Let me know once the notebook is accepted, and I will merge the PR into the main branch.
Hi there,
I've aligned the notebook with the latest template. If you check the preview, you'll notice some minor formatting edits. If you need to review this notebook, please make sure to start from the latest version.
Here is the latest permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/af3a35c62d494212c16fc0044969f956d9a90c8f/Satellite_ECVs/Atmosphere_Physics/satellite_satellite-surface-radiation-budget_climate-monitoring_q01.ipynb
You don't need to re-submit the permalink; the last one you used is still valid.
Data Type
Satellite ECVs - Atmosphere Physics
Assessment Category
Climate Monitoring
Dataset Name
satellite-surface-radiation-budget
Question Number
1
Workflow ID
eqctier3-5dd6e6b1-8b84-4dfe-9f71-18989e55b0a9
Zipped Notebook
srb_q1.zip
Environment
Anything else we need to know?
Hi @malmans2, with @andreastorto we worked to finalize Surface Radiation Budget use case 1. We therefore ask for a permalink. Thanks, Vincenzo