Callbacks recompute predictions

[HCookie]

What happened?

When using the rollout callbacks together, a number of predictions are done multiple times, wasting compute. Both RolloutEval and LongRolloutPlots call the rollout step independently.

What are the steps to reproduce the bug?

Run model with both RolloutEval and LongRolloutPlots enabled

Version

develop, v0.2.1+

Platform (OS and architecture)

ATOS

Relevant log output

No response

Accompanying data

No response

Organisation

ECMWF

[Rilwan-Adewoyin]

?? I propose having a parent HolderCallback class tailored to each type of task:

• Forecasting: RolloutEval
• Reconstruction: ReconstructionEval
• Downscaling: DownscalingEval

Each of these classes would contain task-specific versions of the standard callbacks. For instance, RolloutEval would include PlotLossForecast, while ReconstructionEval would use PlotLossReconstruction. These PlotLoss callbacks could inherit from a general PlotLoss class.

In each parent HolderCallback class, we would manage the forward loop and pass outputs to the relevant task-specific callbacks.