search

ecmwf / cfgrib

A Python interface to map GRIB files to the NetCDF Common Data Model following the CF Convention using ecCodes
Apache License 2.0
407 stars 77 forks source link

Abstract classes for GRIB streams and messages #259

Closed alexamici closed 3 years ago

alexamici commented 3 years ago

Related to #243

codecov-commenter commented 3 years ago

Codecov Report

Merging #259 (a624a51) into master (abed74b) will decrease coverage by 0.30%. The diff coverage is 91.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   96.41%   96.11%   -0.31%     
==========================================
  Files          26       26              
  Lines        1814     1827      +13     
  Branches      211      214       +3     
==========================================
+ Hits         1749     1756       +7     
- Misses         39       44       +5     
- Partials       26       27       +1
Impacted Files Coverage Δ
cfgrib/dataset.py 97.62% <33.33%> (-1.34%) :arrow_down:
cfgrib/abc.py 97.26% <96.82%> (-2.74%) :arrow_down:
cfgrib/messages.py 91.42% <100.00%> (-1.55%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abed74b...a624a51. Read the comment docs.

iainrussell commented 3 years ago

Hi @alexamici, is this something that we can test already? If so, could you provide a small example of what sort of object Metview should provide, and how to call/test it?

Thanks, Iain

alexamici commented 3 years ago

@iainrussell I move the core of the change in PR #265 . It should be almost ready for testing.