Closed chpolste closed 1 week ago
@chpolste , thank you very much for this development. I tested it and works nicely. I made a few comments, once these and the branch conflict are sorted out the PR can be merged.
As for the documentation, what notebook example do you think should be added? What should it highlight?
Attention: Patch coverage is 85.71429%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 91.08%. Comparing base (
acda540
) to head (2598847
). Report is 7 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
tests/readers/test_geotiff_reader.py | 85.71% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
A basic reader for GeoTIFF files using rioxarray under the hood. To address #120.
GeoTIFFReader
,GeoTIFFFieldList
,GeoTIFFField
,GeoTIFFMetadata
andGeoTIFFGeography
.geotiff
optional dependencies inpyproject.toml
.There is not much in terms of metadata extraction other than the projection information yet, but many GeoTIFFs don't provide much metadata in the first place, unfortunately.
I have configured the reader to apply masking and scaling to the values by default, even though rioxarray doesn't.
Small things adjusted along the way:
shape
of thecore.geography.Geography
abstract class into a method (was a property), since that is how it seems to be used in practice.TransverseMercator
projection, which seems to be common for GeoTIFF data.utils.projections.cf.CF_PARAMS_TO_GLOBE_KWARGS["inverse_flattening"]
to"inverse_flattening"
(was"flattening"
).