ecmwf / ecflow

ECMWF's workflow manager
Apache License 2.0
39 stars 15 forks source link

Create abstraction around conversion facilities ECFLOW-1922 #45

Closed marcosbento closed 10 months ago

marcosbento commented 10 months ago

These changes create a thin layer wrapper for conversions between basic types (e.g. std::string, int), allowing to encapsulate all uses of boost::lexical_cast.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (0c7aac9) 80.17% compared to head (07b347e) 80.14%. Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #45 +/- ## =========================================== - Coverage 80.17% 80.14% -0.03% =========================================== Files 575 577 +2 Lines 57874 57855 -19 =========================================== - Hits 46399 46367 -32 - Misses 11475 11488 +13 ``` | [Files](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf) | Coverage Δ | | |---|---|---| | [ACore/src/Converter.hpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvc3JjL0NvbnZlcnRlci5ocHA=) | `100.00% <100.00%> (ø)` | | | [ACore/src/EcfPortLock.hpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvc3JjL0VjZlBvcnRMb2NrLmhwcA==) | `78.26% <ø> (-0.91%)` | :arrow_down: | | [ACore/src/Extract.cpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvc3JjL0V4dHJhY3QuY3Bw) | `100.00% <100.00%> (ø)` | | | [ACore/src/Str.cpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvc3JjL1N0ci5jcHA=) | `95.78% <100.00%> (-0.02%)` | :arrow_down: | | [ACore/src/Str.hpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvc3JjL1N0ci5ocHA=) | `100.00% <ø> (ø)` | | | [ACore/src/TimeSlot.cpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvc3JjL1RpbWVTbG90LmNwcA==) | `84.37% <100.00%> (ø)` | | | [ACore/src/perf\_timer.hpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvc3JjL3BlcmZfdGltZXIuaHBw) | `100.00% <ø> (ø)` | | | [ACore/test/TestCalendar.cpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvdGVzdC9UZXN0Q2FsZW5kYXIuY3Bw) | `90.08% <ø> (-0.05%)` | :arrow_down: | | [ACore/test/TestClassDataMemberInit.cpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvdGVzdC9UZXN0Q2xhc3NEYXRhTWVtYmVySW5pdC5jcHA=) | `100.00% <ø> (ø)` | | | [ACore/test/TestCommandLine.cpp](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf#diff-QUNvcmUvdGVzdC9UZXN0Q29tbWFuZExpbmUuY3Bw) | `100.00% <100.00%> (ø)` | | | ... and [78 more](https://app.codecov.io/gh/ecmwf/ecflow/pull/45?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/ecmwf/ecflow/pull/45/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ecmwf)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.