search

ecmwf / fdb

Fdb is a domain-specific object store for meteorological objects
Apache License 2.0
26 stars 11 forks source link

Remote fdb #54

Open Ozaq opened 5 days ago

Ozaq commented 5 days ago

I think this change also needs a couple of high level system tests, e.g. 2 FDB instances one as local, L. And another one as remote R, where R talks to L.

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 21.18644% with 2139 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (718cfc1) to head (d0af10f). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/fdb5/remote/server/ServerConnection.cc 0.00% 331 Missing :warning:
src/fdb5/remote/client/ClientConnection.cc 0.00% 276 Missing :warning:
src/fdb5/remote/server/CatalogueHandler.cc 0.00% 263 Missing :warning:
src/fdb5/remote/client/RemoteStore.cc 0.00% 227 Missing :warning:
src/fdb5/remote/server/StoreHandler.cc 0.00% 149 Missing :warning:
src/fdb5/api/RemoteFDB.cc 0.00% 123 Missing :warning:
src/fdb5/remote/client/RemoteCatalogue.cc 0.00% 115 Missing :warning:
src/fdb5/io/FieldHandle.cc 43.19% 96 Missing :warning:
src/fdb5/remote/Connection.cc 0.00% 87 Missing :warning:
src/fdb5/remote/client/ClientConnectionRouter.cc 0.00% 66 Missing :warning:
... and 50 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #54 +/- ## =========================================== - Coverage 64.51% 61.08% -3.43% =========================================== Files 238 266 +28 Lines 13844 15084 +1240 Branches 1334 1508 +174 =========================================== + Hits 8931 9214 +283 - Misses 4913 5870 +957 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.