ecn310 / course-project-development

How has the link between manufacturing employment and economic growth evolved over time and across countries.
0 stars 0 forks source link

Feedback #1

Open github-classroom[bot] opened 6 months ago

github-classroom[bot] commented 6 months ago

:wave:! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher. In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens. Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to the default branch since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to the default branch. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @Meiska12 @filod204 @lirioslu @spsotelo

filod204 commented 4 months ago

Dear prof. Buzard, When I ran the do file after closing everything and before uploading, it did not give me an error. Regarding the dataset on WDI, I reset it, selected every country, all time periods, and the variables listed in our latex file only, then downloaded it.

Best, Filippo

Da: Kristy Buzard @.> Data: sabato, 2 novembre 2024 alle ore 18:06 A: ecn310/course-project-development @.> Cc: Filippo Dona @.>, Mention @.> Oggetto: Re: [ecn310/course-project-development] Feedback (PR #1)

@kbuzard commented on this pull request.


In WDI.dohttps://github.com/ecn310/course-project-development/pull/1#discussion_r1826861903:

  • import excel "C:\Users\fadona\Downloads\P_Data_Extract_From_World_Development_Indicators.xlsx", sheet("Data") firstrow

+drop SeriesCode

+gen id = _n

+reshape long YR, i(id) j(year)

+encode SeriesName, gen(varnum)

+label save varnum using vardesc, replace

+drop id SeriesName

+rename YR data

+egen id = group(CountryName year)

@ecn310/developmenthttps://github.com/orgs/ecn310/teams/development This is a good start. It errors out for me on line 9, because CountryName doesn't exist.

— Reply to this email directly, view it on GitHubhttps://github.com/ecn310/course-project-development/pull/1#pullrequestreview-2411745875, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BK2MITJIYT4547C4IMIMZY3Z6VEFTAVCNFSM6AAAAABN675IRKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJRG42DKOBXGU. You are receiving this because you were mentioned.Message ID: @.***>