search

eddelbuettel / r2u

CRAN as Ubuntu Binaries
https://eddelbuettel.github.io/r2u
247 stars 17 forks source link

Step 2 in the README uses the Jammy url instead of Noble #68

Closed Constancies closed 2 months ago

Constancies commented 2 months ago

In Step 2 of the README's install process, this line points to the Jammy repo even though 24.04 is out and supported:

echo "deb [arch=amd64] https://r2u.stat.illinois.edu/ubuntu jammy main" \
     > /etc/apt/sources.list.d/cranapt.list

This can be solved by changing those lines to this, so that it will automatically detect the Ubuntu version:


echo "deb [arch=amd64] https://r2u.stat.illinois.edu/ubuntu $(lsb_release -cs) main" \
     > /etc/apt/sources.list.d/cranapt.list
eddelbuettel commented 2 months ago

I think we need to take the $(lsb_release -cs) outside the double quotes. So

 echo "deb [arch=amd64] https://r2u.stat.illinois.edu/ubuntu" $(lsb_release -cs) "main" \
      > /etc/apt/sources.list.d/cranapt.list

is likely better. (And I should add a line that scripts in directory inst/scripts/ are available and tested.)

eddelbuettel commented 2 months ago

We actually say right before step 1:

We show the setup step by step for 'jammy' aka Ubuntu 22.04.

eddelbuettel commented 2 months ago

It also misssed "jammy-cran40" in the step for R binaries. So I decided to leave the steps at "jammy", but mention lsb_release -cs explicitly just before. So thanks for the note, now addressed.