edestecd / puppet-clamav

Puppet Module for managing ClamAV
GNU General Public License v3.0
6 stars 59 forks source link

Convert to Puppet 4 conventions #49

Closed edestecd closed 4 years ago

edestecd commented 7 years ago

Use a puppetlabs module as an example and for god sakes use module sync!

pillarsdotnet commented 6 years ago

I'm working on this, and also adding support for Windows.

edestecd commented 6 years ago

WOW! thanks. I was planning on getting to this eventually, but would be very appreciative if you did it :smile:

edestecd commented 6 years ago

I need to get back to #38 also... I'll try and get to that tomorrow

pillarsdotnet commented 6 years ago

Good info here: https://docs.puppet.com/puppet/5.3/hiera_migrate_modules.html

pillarsdotnet commented 6 years ago

Started work here.

Not done by a long shot.

edestecd commented 6 years ago

Cool. I'm all for using hiera 5 instead of params.pp. I hate reading through that mess. ITs nice to finally have a good alternative.

edestecd commented 6 years ago

I'm all for doing work in small chunks. Can you make a separate issue/PR for adding Windows.