search

edgecase / ghpreview

Preview Markdown files (such as a README) exactly how it will appear on Github
MIT License
27 stars 4 forks source link

Update gems to make it work again #20

Closed picandocodigo closed 4 years ago

picandocodigo commented 7 years ago

Not sure if the intention is to keep maintaining this gem, but I wanted to install it recently and found it didn't work with Ruby 2.4. I managed to fix it for me by updating the gems and replacing html-pipeline's SyntaxHighlightFilter with RougeFilter.

jacksenechal commented 4 years ago

This looks good to me. @adamlogic do you want to merge this and publish the updated gem?

picandocodigo commented 4 years ago

@jacksenechal thanks for looking into this after so long. I updated some gems to a newer version. Will this still be maintained?

adamlogic commented 4 years ago

Thanks for the work here. I haven't used this gem in years, but I'm happy to hand the keys over if one of you wants to maintain it.

picandocodigo commented 4 years ago

Hi @adamlogic :wave: I still use the gem every now and then, so I'd be happy to maintain it!

adamlogic commented 4 years ago

@picandocodigo Awesome! I just gave you write access to the repo. Need your email to add you as an owner for the gem. I don't see it listed in your GH profile, so you can email it to me if you want (my email address is listed in my GH profile).