search

edgurgel / httpoison

Yet Another HTTP client for Elixir powered by hackney
https://hex.pm/packages/httpoison
MIT License
2.23k stars 341 forks source link

Add body parameter to delete and delete! functions #449

Closed asher-scott closed 3 years ago

asher-scott commented 3 years ago

Addresses Issue #284 Updated the delete and delete! functions in HTTPoison.Base to additionally accept an optional body parameter.

edgurgel commented 3 years ago

Hey! Thanks for the PR but this would be a breaking change that I don't think it's worth doing right now.

A delete with a body is something that was considered wrong and just recently it has been allowed but without a defined semantic : https://stackoverflow.com/a/10015724/1544452

If someone needs to send a delete with a body they can use request/5 or request/1