Enable social media sharing from the app

edina / CuriousEdinburgh2

University of Edinburgh project developing a platform independent app for guided walking tours of sites of scientific and cultural interest in and around Edinburgh.

http://curiousedinburgh.org/

2 stars 1 forks source link

Enable social media sharing from the app #90

Closed NicolaOsborne closed 6 years ago

NicolaOsborne commented 7 years ago

From the tour stop pages: enable social media sharing of the page.

Channels

Facebook
Twitter
Email
Instagram (if available)

What should be shared?

Title of page
URL of (blog) page
First thumbnail from tour stop
@curiousedi handle.

Suggested format: "Exploring with @curiousedi. "

gmh04 commented 7 years ago

Due to a runtime error with RN 0.48 (undefined is not an object (evaluating '_react2.default.PropTypes.func') in DefaultTabBar.js in react-native-scrollable-tab-view) I have had to downgrade to RN 0.47. This is a shame as a Sharing dialog is now available in the core api https://facebook.github.io/react-native/docs/share.html which is not in 0.47. So I have installed https://github.com/EstebanFuentealba/react-native-share which works and looks mature. In android clicking on the share link invokes the native sharing popup,

I just need from @NicolaOsborne an idea of how you want this to look on this page. It is currently a simple link below Associated Links.

NicolaOsborne commented 7 years ago

@gmh04 can you provide a screenshot of this or demo it so I have an idea of what is possible please?

gmh04 commented 7 years ago

I've just added a link to the bottom of the page, to get an idea of what the share will look like on different devices see https://facebook.github.io/react-native/docs/share.html screenshot_20170912-110119

gmh04 commented 7 years ago

also @NicolaOsborne, look at the options for sharing. The url is either a url (of the tour stop or a base64 image) see https://github.com/EstebanFuentealba/react-native-share#user-content-openoptions. Presumably you would prefer the URL of the tour stop and drop the first thumbnail from tour stop? You want the message to be "Exploring with @curiousedi. "?

NicolaOsborne commented 7 years ago

Thanks @gmh04.

For the tourstop page: rather than "Simple Share" can we please change the text to "Share this Tour Stop"?

For the sharing options:

URL should be the tour stop
Exploring <Tour Stop Name/Title of Page> with @curiousedi

If the tour stop name is not doable, then yes, "Exploring with @curiousedi" would be fine.

gmh04 commented 7 years ago

Android done. assigning to @jollopre for IOS setup: https://github.com/EstebanFuentealba/react-native-share#user-content-ios

jollopre commented 7 years ago

iOS setup completed and working properly.