edmcouncil / idmp

This repository stores the OWL ontology built on the basis of the ISO standards for identification of medicinal products.
https://spec.edmcouncil.org/idmp/
MIT License
32 stars 10 forks source link

IDMP-744 - Investigate simplifying potential circularities in the packaging / container specification part of the ontology #642

Closed ElisaKendall closed 1 week ago

ElisaKendall commented 1 month ago

Description:

  1. Simplified the packaging model by eliminating container constituency and revising the definition of medicinal product container (of which package item is a subclass) accordingly, as well as a redundant restriction on package item
  2. Revised the Amlodipine example to reflect these changes
  3. Revised the Qlaira example to reflect these changes
tw-osthus commented 1 month ago

Adding package item -has constituent -> package constituent makes package item a constituency by inference. This is ok, because package item is a specification/definition of a physical item based largely on how it is composed. So from that side I approve and like this change.

However I do not like the current definition (coming from the idmp spec) of package item, a subclass of material specification , which if can likely be misunderstood as a physical thing and if that were the case it would be inconsistent. An explanatory note is needed, if we want to keep the definition.

ElisaKendall commented 1 month ago

Adding package item -has constituent -> package constituent makes package item a constituency by inference. This is ok, because package item is a specification/definition of a physical item based largely on how it is composed. So from that side I approve and like this change.

However I do not like the current definition (coming from the idmp spec) of package item, a subclass of material specification , which if can likely be misunderstood as a physical thing and if that were the case it would be inconsistent. An explanatory note is needed, if we want to keep the definition.

Fixed