search

edo9300 / edopro

A script engine for "yu-gi-oh!" and sample gui (former "ygopro")
Other
286 stars 76 forks source link

Audio playback is simply different #135

Open kevinlul opened 4 years ago

kevinlul commented 4 years ago

There were a few sporadic reports of audio playback differences from irrKlang. This is probably a parameter that we can change somewhere with SDL mixer. You can reproduce this for yourself by sitting in the game menu and then opening the same menu music with a player like VLC.

kevinlul commented 4 years ago

The issue is here https://github.com/edo9300/edopro/blob/master/gframe/sound_sdlmixer.cpp#L20 where we start the sound device at 22.05 kHz , alongside some other settings. According to the documentation, turning EDOPro into a music player may hurt performance on older machines, but we could possibly externalize these to configs for advanced users and audiophiles.

muxe1109 commented 4 years ago

The advantages and disadvantages music are swapped

LordYuuma commented 4 years ago

Since the backend is selected at compile time, should this be fixed at compilation as well? Or should we instead go with a factory approach, where we compile both irrKlang and SDL (if available) and then select the backend and options based on e.g. audio.conf?