Incorrect Settings Loaded for Chat Mute Options

edo9300 / edopro

A script engine for "yu-gi-oh!" and sample gui (former "ygopro")

Other

286 stars 76 forks source link

Incorrect Settings Loaded for Chat Mute Options #143

Closed Zeph72 closed 4 years ago

Zeph72 commented 4 years ago

When settings are loaded from system.conf on program launch, the value for 'mute_spectators' is applied to the mute opponent setting instead. This seems to also result in the setting for muting spectators to fall back to a default value of false.

The offending line is 134 here: https://github.com/edo9300/edopro/blob/f50d6869388f37f4f5dd9f4ca3201d6f151c4221/gframe/game_config.cpp#L131-L134

Thanks!

kevinlul commented 4 years ago

Hi there! Great catch. If you're interested in fixing this, you can submit a pull request! Otherwise I will get around to it when I have time.

edo9300 commented 4 years ago

Fixed in https://github.com/edo9300/edopro/commit/45c1ee56849f9ba10ed78310c652723b95dc8f4a