edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 158 forks source link

Mouse scroll wheel and touchpad scroll gesture support #1436

Open PhilippeBruno opened 3 years ago

PhilippeBruno commented 3 years ago

Two suggestions:

danielweck commented 3 years ago

When using Thorium on a Windows machine, it would be nice to be able to use mouse scroll wheel to flip pages.

Agreed.

This functionality is in fact already implemented on all 3 supported desktop platforms (MacOS, Linux, Windows), BUT ONLY when placing the mouse cursor over the bottom "scrub bar" / reading progression slider.

This is an experimental feature. Usability is currently sub-optimal (i.e. the same mouse wheel / scroll control should be afforded over the main content area, not just confined to the small bottom UI area). More importantly, the scroll event is currently throttled, which creates an unintuitive / unnatural experience when turning pages. Furthermore, scroll inertia causes confusion (e.g. when swiping across a MacOS touch trackpad, book pages turn in an uncontrollable manner).

danielweck commented 3 years ago

Related issue: https://github.com/edrlab/thorium-reader/issues/725

* When using Thorium on a tablet PC (Microsoft Surface, etc.) or a touch screen PC, it would be nice to swipe the screen from right to left and from left to right to turn pages. I was reading an EPUB in bed tonight on my Microsoft Surface and at several occasions, I was trying to turn pages with gestures...

The "touch gesture" part of this new issue is effectively a duplicate of the older issue (link above), so please allow me to rename the issue title, so that the scope here is "mouse scroll wheel / touchpad scroll gesture".

danielweck commented 3 years ago

To summarize, there are now two separate but related issues:

PhilippeBruno commented 3 years ago

Before I post a suggestion, I try to search if someone made that suggestion before. Sorry I missed the gesture one.

blsz commented 3 years ago

Could there be an option to reverse scrolling direction for desktops? There is little consensus on natural scrolling in the case of trackpads and scroll wheels.

llemeurfr commented 3 years ago

It is true that I use "inverted" scrolling direction on my Mac, but on the bottom area, scroll & page turn are active in the "original" direction: user configuration is not taken into account.

JayceTheBased commented 2 years ago

When using Thorium on a Windows machine, it would be nice to be able to use mouse scroll wheel to flip pages.

Agreed.

This functionality is in fact already implemented on all 3 supported desktop platforms (MacOS, Linux, Windows), BUT ONLY when placing the mouse cursor over the bottom "scrub bar" / reading progression slider.

This is an experimental feature. Usability is currently sub-optimal (i.e. the same mouse wheel / scroll control should be afforded over the main content area, not just confined to the small bottom UI area). More importantly, the scroll event is currently throttled, which creates an unintuitive / unnatural experience when turning pages. Furthermore, scroll inertia causes confusion (e.g. when swiping across a MacOS touch trackpad, book pages turn in an uncontrollable manner).

I just tried out Thorium yesterday and absolutely love the layout options. I think this program would be my favorite ereader program by far were it not for the fact that you need to put the cursor over the progression slider to scroll with the mouse wheel. Given that I often use reading as a quick break between other tasks, it's a bit annoying to have to keep moving my cursor back over the small bar on the bottom to be able to switch pages with my mouse.

Is there any chance that you @danielweck and/or the rest of the team could resolve this issue by expanding the scroll control functionality to the main content area? Thanks so much for all your hard work on this and hope this doesn't come across as too demanding - I don't have much experience with github so I apologize if it's not appropriate for me to bring up an old issue.