search

educational-technology-collective / morf

The MOOC Replication Framework (MORF)
MIT License
16 stars 7 forks source link

Upgrades to `send_success_email` #25

Open jpgard opened 6 years ago

jpgard commented 6 years ago

At least two changes need to be made to alerts.send_success_email():

  1. Success emails should only be sent if the entire job completes successfully (currently, even if there is an exception thrown while job is running, the platform currently still tries to send a success email but it should not)
  2. Success emails themselves should "fail" gracefully in the case of partial jobs-- if there is no result file, for example (sometimes someone might just run a feature extraction job, with no training/testing), we should be able to still send the email and also continue execution of the MORF script without failing.