search

edulify / play-hikaricp.edulify.com

HikariCP Plugin for Playframework 2.2.x and 2.3.x
http://edulify.github.io/play-hikaricp.edulify.com/
Apache License 2.0
82 stars 35 forks source link

Enabling support for Java 6 and Scala 2.10 #72

Closed daniel-anjos-zeroturnaround closed 9 years ago

daniel-anjos-zeroturnaround commented 9 years ago

I have upgraded the dependencies so HikariCP 2.3.9 can be used with a Play 2.3.10 application with Java 6 and built with Scala 2.10

megazord commented 9 years ago

Hello @daniel-anjos-zeroturnaround,

I was not planning to support Java 6 here because it reached end of life support (even Java 7 is not officially supported by Oracle anymore). Also, HikariCP has used some Java 8 features to have a better performance. Anyway, as this PR shows, create your own build is pretty simple and straightforward.

daniel-anjos-zeroturnaround commented 9 years ago

Hi @megazord thanks for the reply - I will use the internal build from the fork.

One note: HikariCP is still supporting Java7 on their latest build, so in the next plugin update you may consider it as well? - https://github.com/brettwooldridge/HikariCP/issues/471

(The reason we cannot migrate to Play 2.4 and have to use Play 2.3 and the HikariCP plugin is exactly the Java 6/7 constrain from business side).

Cheers