search

eduncan911 / podcast

iTunes and RSS 2.0 Podcast Generator in Golang
MIT License
132 stars 35 forks source link

Fix an error message typo #6

Closed guywithnose closed 7 years ago

eduncan911 commented 7 years ago

I am not sure why Coveralls is failing in the Travis build. It works for my other PR #5 that I have open.

I've opened a ticket with Coveralls to see what's up.

As for the actual PR, LGTM! I'll squash and push it up as soon as I hear from Coveralls.

OT: What do you think about that podcast.New() API method? Simple? Overly complex? Should/shouldn't use nils? etc?

I previously had open a discussion issue #2 where I was thinking of refactoring it. But, it would break existing compatibility.

Feel free to comment in #2 about more details. I am open to feedback, especially since I am working on #5 ATM which will be a Version 2.x milestone.

eduncan911 commented 7 years ago

Still not sure why coveralls still fails. Perhaps it's because your repo doesn't have access to my coveralls account?

Regardless, they never responded to my open support request.

I'll go ahead and merge this since other tests shows 100% coverage anyways.