edvin / fxlauncher

Auto updating launcher for JavaFX Applications
Apache License 2.0
714 stars 110 forks source link

Icon of windows executable not change #67

Closed arthurcvm closed 7 years ago

arthurcvm commented 7 years ago

I set in my pom.xml the icon of application:

`

installer
                    <phase>install</phase>
                    <goals>
                        <goal>exec</goal>
                    </goals>
                    <configuration>
                        <executable>javapackager</executable>

                        <arguments>
                            <argument>-deploy</argument>
                            <argument>-native</argument>
                            <argument>-outdir</argument>
                            <argument>${app.installerdir}</argument>
                            <argument>-outfile</argument>
                            <argument>${app.filename}</argument>
                            <argument>-srcdir</argument>
                            <argument>${app.dir}</argument>
                            <argument>-srcfiles</argument>
                            <argument>fxlauncher.jar</argument>
                            <argument>-appclass</argument>
                            <argument>fxlauncher.Launcher</argument>
                            <argument>-name</argument>
                            <argument>${project.name}</argument>
                            <argument>-title</argument>
                            <argument>${project.name}</argument>
                            <argument>-vendor</argument>
                            <argument>${app.vendor}</argument>
                            <argument>-Bicon=src/main/resources/favicon.ico</argument>
                            <argument>-BshortcutHint=true</argument>
                            <argument>-BmenuHint=true</argument>
                            <argument>-BappVersion=${app.version}</argument>
                            <argument>-Bidentifier=${project.groupId}.${project.artifactId}</argument>
                        </arguments>
                    </configuration>
                </execution>`

In install is all ok, but in installer archive (.exe) the icon not change, look:

2017-04-17 1

2017-04-17 2

And in the launcher:

2017-04-17 4

ronsmits commented 7 years ago

The icon is a seperate thing, the startup error seems to be SCP and windows related investigating

arthurcvm commented 7 years ago

The error of launcher is because I still don't configure de server. But about the icon, in javafx maven plugin I change icon in bundler options in pom.xml and solve this.

edvin commented 7 years ago

So you're all good? Can we close the issue?

arthurcvm commented 7 years ago

Not solve nothing, please close the issue.