search

edvin / tornadofx

Lightweight JavaFX Framework for Kotlin
Apache License 2.0
3.67k stars 269 forks source link

An expandable table row with dirty tracking #1147

Open kenfehling opened 4 years ago

kenfehling commented 4 years ago

Hi, thank you for this project! I realized it's not possible to have a tableview with both enableDirtyTracking and rowExpander; they both call setRowFactory, so one clobbers the other. I'm wondering if there's a simple way to compose the two, or any other suggestions.

edvin commented 4 years ago

Ah, you're right. Some places in the framework we have mechanisms for stacking factories. I don't think we've implemented it for rowFactory, but it wouldn't be hard to do. You can also do it manually by creating a row factory that includes code from both enableDirtyTracking and rowExpander.

I don't have time to create support for stacking row factories right now, but a PR for it would be most welcome :)