WIP on configurable cluster names

edwardcapriolo / gossip

A Mavenized Apache V2 gossip implementation for Java

Apache License 2.0

160 stars 54 forks source link

Closed ptgoetz closed 8 years ago

ptgoetz commented 8 years ago

As discussed, here's the pull request. No need to merge unless you want to. This was just an exercise for me to get familiar with the codebase.

edwardcapriolo commented 8 years ago

Looks great. Did you think it makes sense to do a negative test that proves with two different cluster names the node does not join?

ptgoetz commented 8 years ago

Yeah, that was my next step. This was just the first commit. Got a little distracted by that incubator thing... :)

edwardcapriolo commented 8 years ago

Ok I will merge this for now as all positive tests still pass.