edwardchalstrey1 / seshat

This is the beginning of the Seshat Project code.
0 stars 2 forks source link

Bug: Present/absent variables don't correctly represent dates #149

Closed edwardchalstrey1 closed 1 month ago

edwardchalstrey1 commented 1 month ago

Display of the present/absent values were not reflecting any date specific restrictions. Here is an example.

For the Dutch Empire (which is named Dutch Republic in the shape, likely to change) the db states that before 1673 they did not have professional military officers, and then they did (see the year_from/year_to bits…if they are empty then it applies to the entire polity year_from/year_to dates):

subsection|variable_name|year_from|year_to|polity_name|polity_new_ID|polity_old_ID|value_from|value_to|confidence|is_disputed|is_uncertain|expert_checked|DRB_reviewed Professions|professional_military_officer|1648|1672|Dutch Empire|nl_dutch_emp_1|nl_dutch_emp_1|absent||Confident|False|False|False| Professions|professional_military_officer|1673|1795|Dutch Empire|nl_dutch_emp_1|nl_dutch_emp_1|present||Confident|False|False|False|

Screen Shot 2024-05-17 at 10 23 11 AM

edwardchalstrey1 commented 1 month ago

TODO: