search

edzer / sp

Classes and methods for spatial data
http://edzer.github.io/sp/
128 stars 27 forks source link

preserve SF comment in "[" for SpatialPolygons* #108

Closed rsbivand closed 3 years ago

rsbivand commented 3 years ago

BDRs revdep for FlexScan showed that the simple-features comment on an sp polygons object was lost when subsetting, and this was needed to avoid sf::st_as_sfc() calling rgeos::createSPComment(). Please check that this makes sense.

edzer commented 3 years ago

Is simply copying the comment the right thing to do when the object is being subsetted?

edzer commented 3 years ago

Ah, I see, on top level objects comment() is TRUE or FALSE, indicating whether they're set on the individual multipolygons.

rsbivand commented 3 years ago

Any possibility of merging this and preparing an sp submission? I'd like the next sp after this and the next rgdal releases to flip the lost datum warnings option from "all" to "none", but I'd like the cumulated sp fixes out first. I don't see any revdep problems.

Next after that might be the spatstat coercion methods?

edzer commented 3 years ago

Thanks, will submit soon!