In source now-defunct Pants team fork of Jar Jar Links

er1c commented 3 years ago

Addresses #11 (at least partially) and fixing https://github.com/eed3si9n/jarjar-abrams/pull/15

Created a copy of https://github.com/pantsbuild/jarjar with git-history as jarjar subproject
Updated build.sbt and README to reference the jarjar project and where it came from
Added a KeepProcessorTest and fix.
Added a best-guess for BigtableIO$Write.class since no version was available (test passes though)
Moved the org.pantsbuild.jarjar.integration into jarjar/src/it and removed the pants dependency

er1c commented 3 years ago

Verified that this fixes the sbt-assembly test failure, but I'd like to do some more tests, I need to split the actual fix out from the big commit too to make easier to review.

er1c commented 3 years ago

@alexarchambault do you want to review this? what was the issue with the ASM?

er1c commented 3 years ago

✅ with the CI tests now running/passing

eed3si9n / jarjar-abrams

In source now-defunct Pants team fork of Jar Jar Links #15