Closed gabrielrussoc closed 3 years ago
Thanks for the contribution!
For the failure, I htink you just need .linesIterator
although maybe I'm thinking about the scala method and not the java one
[error] /home/runner/work/jarjar-abrams/jarjar-abrams/jarjar/src/main/java/com/eed3si9n/jarjar/ResourceProcessor.java:59:1: cannot find symbol
[error] symbol: method lines()
[error] location: variable s of type java.lang.String
[error] s.lines
@gabrielrussoc thanks again for the contribution! Going to add an uber assembly on the next published version via: https://github.com/eed3si9n/jarjar-abrams/pull/23
I believe this has been a known issue since 2009: https://code.google.com/archive/p/jarjar/issues/30
This seems to be the only actively maintained fork of jarjar I could find, so I decided to contribute here.
I added some tests to the ResourceProcessor.
Since we are only using the jarjar cli, I also added the assembly plugin in order to build an uber jar. There were some
module-info.class
clashes so I simply ignored them since we will build it with jdk 8 (and they are most likely useless):