search

eed3si9n / jarjar-abrams

an experimental Scala extension of Jar Jar Links
27 stars 21 forks source link

Add `zapFile` rule type #49

Closed acourtneybrown closed 9 months ago

acourtneybrown commented 10 months ago

Analogous to zap rule type, which only allows for omitting .class files, this change adds a zapFile type that will omit any file based on the path and wildcarding support available to other rules.

Fixes: eed3si9n/jarjar-abrams#48

johnynek commented 9 months ago

Sorry I didn't comment on this PR. I noticed the PR was red in CI and didn't check back.

I did appreciate your contribution and I think it would be nice to have general file processing abilities in the code.

acourtneybrown commented 9 months ago

@johnynek I've moved on from the company where this change was relevant, so it's no longer "my problem to worry about"™️. I was just cleaning up things that I was not going to come back to and the PR closure had nothing to do with the repo codeowners 😄 .