joewiz
commented
2 years ago The CI failure here is the same one affecting the master branch since the most recent commit: https://github.com/eeditiones/tei-publisher-app/commit/5b6f0ad487e025730acf9e16f1637cc8e471914d. CI logs: https://github.com/eeditiones/tei-publisher-app/runs/6227804975?check_suite_focus=true.
I see that https://github.com/eeditiones/tei-publisher-app/pull/96 is intended to fix this CI issue. Once it's merged let's re-run CI here.
Closes #98.
Note that the following links indicate that for Docker purposes we are recommending 5.3.1:
I'd be happy to adjust this PR to require eXist 5.3.1 if that's better for consistency.
Also, the README could probably be added to this PR. It currently states:
I think the more accurate statement is that from version 7.1.0 TEI Publisher requires eXist 5.2.0 - see https://github.com/eeditiones/tei-publisher-app/commit/a6c3708de5b71ddd09ac4b342010a7c44c366517. (We'd just need to update this statement again when TEI Publisher 8 is released... updating in this PR would be premature.)
(Also, that link to bintray should be updated to eXist's GitHub Releases page.)
Also, the README references "existdb/teipublisher:6.0.0" when discussing the Docker images - whereas the current release to DockerHub is 7.1.0 (or 7.1.0-patched?).
And the README's statement that the Docker image "installs 5.2.0" should be updated to say "5.3.1." So README could be updated here. I'd happily do so in this PR if anyone would tell me what exactly to replace ":6.0.0" with - should it be ":7.1.0" or ":7.1.0-patched"? Or would ":latest" be better? I honestly don't know.