Code cleanup and new features

eefret / gomdb

Omdb API in golang

Apache License 2.0

17 stars 14 forks source link

Code cleanup and new features #10

Closed agnivade closed 8 years ago

agnivade commented 8 years ago

Hi there,

Thank you for the good work in writing the library. I forked it and added a little bit of polish. Below is a list of items covered in the PR-

Now passing a struct in the API functions. This makes the API more scalable if more fields are to come in the future. And you don't have to pass "" if you don't want to search by a certain field.
Added search by type. #4
Added much more unit tests. And added fail scenario too.

codnee commented 8 years ago

Please update the README to point to the original repo.

@efreet: thoughts?

agnivade commented 8 years ago

Ahh crap, problems of sending PR from the master branch. When I made the PR, the README was indeed pointing to the original repo. Then I made the changes to point to my repo, which got reflected in the PR as well.

Fixed it now.

eefret commented 8 years ago

sorry for the late, checking it right now

agnivade commented 8 years ago

@eefret - Oops. Fixed it.

eefret commented 8 years ago

I agree with the changes thanks for the PR, merging