search

eefret / gomdb

Omdb API in golang
Apache License 2.0
17 stars 14 forks source link

add support for API keys #12

Closed alexguzun closed 6 years ago

alexguzun commented 7 years ago

As you might know, the API now requires a key, that can be obtained by becoming a suporter. Current version of library does not work anymore ( Issue #11 ).

Unit tests are getting the key from environment: var apiKey = os.Getenv("OMDB_API_KEY")

This also means that one will have to configure the environment variable in TravisCI.

eefret commented 7 years ago

Thanks for adding this, I will add a testing key and merge before this weekend. Thanks a lot.

alexguzun commented 6 years ago

Hi @eefret! Any updates on this PR?

eefret commented 6 years ago

Yeah sure I downloaded the build and the tests work correctly

eefret commented 6 years ago

thanks @alexguzun

alexguzun commented 6 years ago

Thanks for merging the PR! Don't forget to configure the environment variable in TravisCI.