Db2RdbmsSpecifics implementation is not thread-safe

[GoogleCodeExporter]

Probably,Db2RdbmsSpecifics implementation is not thread-safe. 
Because SimpleDateFormat is not thread-safe...

public class Db2RdbmsSpecifics extends RdbmsSpecifics {

        private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat(
                        "'TIMESTAMP('''yyyy-MM-dd HH:mm:ss.SSS''')'");

        public Db2RdbmsSpecifics() {
                super();
        }

        @Override
        public String formatParameterObject(Object object) {
                if (object instanceof Date) {
                        return DATE_FORMAT.format((Date) object);
                } 
                return super.formatParameterObject(object);
        }
}

Original issue reported on code.google.com by kazuki43zoo on 4 Oct 2014 at 1:22

[GoogleCodeExporter]

Just to save me some search, is RdbmsSpecifics thread-safe? (meaning, the 
problem only comes from the DATE_FORMAT attribute, not from the returned 
SimpleDataFormat)?

Original comment by frederic...@gmail.com on 6 Oct 2014 at 11:49

• Changed state: Accepted

[GoogleCodeExporter]

RdbmsSpecifics is thread safe because create instance of SimpleDateFormat per 
method call.
SimpleDateFormat method is not supported execution under the multithreaded 
environment.(http://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat
.html#synchronization)

I does not good at English,  is ok with this answer ?

Original comment by kazuki43zoo on 6 Oct 2014 at 12:20

[GoogleCodeExporter]

As one cases, FastDateFormat(Common-lang) & Joda-Time is thread-safe libraries.

Original comment by kazuki43zoo on 6 Oct 2014 at 12:36

[GoogleCodeExporter]

Yes, of course, thanks, I will fix this quickly. 

Original comment by frederic...@gmail.com on 7 Oct 2014 at 4:06

[GoogleCodeExporter]

Original comment by frederic...@gmail.com on 31 Jan 2015 at 11:10

• Changed state: Started