search

efmarshall / h2database

Automatically exported from code.google.com/p/h2database
0 stars 0 forks source link

Important fix on ValueGeometry #509

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Here a patch with more unit test and fix on Geometry type of H2:

https://github.com/nicolas-f/h2database/commits/patch/fixValueGeometry

* Fix ValueGeometry.equals with a binary equality check of WKB.
* Faster dimension check, use advised method by Martin Davis (author of JTS)
* Fix conversion of ValueGeometry into JavaObject (you should found a better 
fix)

Create unit test for all fix.

Thank you.

Original issue reported on code.google.com by nico.de...@gmail.com on 3 Oct 2013 at 1:25

GoogleCodeExporter commented 9 years ago 
Hi,

Do you know, is there a way to export a patch file from this link? Or do I have 
to download the git repository myself and create a patch from that?

Original comment by thomas.t...@gmail.com on 6 Oct 2013 at 6:40

GoogleCodeExporter commented 9 years ago 
Committed in revision 5211.

Note that I changed the "illegal ValueGeometry" part of the patch.

We cannot allow such values to exist at all, because we use WKB format for 
persistence.

Original comment by noelgrandin on 9 Oct 2013 at 8:40

GoogleCodeExporter commented 9 years ago 
Thank you very much. All unit test of H2GIS successfully pass with h2 trunk now 
! Happy to get rid of our h2 fork !

Original comment by nico.de...@gmail.com on 9 Oct 2013 at 8:59