egobsv / Tenoli-LAT

Interoperabilidad distribuida usando firma electrónica
1 stars 6 forks source link

Error compiling project due to missing method #6

Closed alblandino closed 3 years ago

alblandino commented 3 years ago

There is a problem when compiling the project and it is due to this file

It happens that in line # 65 it is referring to a method that is not defined in the same class, so it causes an error, so I propose to add this:

    private static ClientId parseClientIdFromLegacyName(X500Name x500name) {
        String c = getRDNValue(x500name, BCStyle.C);
        if (!"SV".equals(c)) {
            throw new CodedException(ErrorCodes.X_INCORRECT_CERTIFICATE,
                    "Certificate subject name does not contain valid country code");
        }

        String instanceId = getRDNValue(x500name, BCStyle.O);
        if (instanceId == null) {
            throw new CodedException(ErrorCodes.X_INCORRECT_CERTIFICATE,
                    "Certificate subject name does not contain organization");
        }

        String memberClass = getRDNValue(x500name, BCStyle.OU);
        if (memberClass == null) {
            throw new CodedException(ErrorCodes.X_INCORRECT_CERTIFICATE,
                    "Certificate subject name does not contain organization unit");
        }

        String memberCode = getRDNValue(x500name, BCStyle.CN);
        if (memberCode == null) {
            throw new CodedException(ErrorCodes.X_INCORRECT_CERTIFICATE,
                    "Certificate subject name does not contain common name");
        }

        return ClientId.create(instanceId, memberClass, memberCode);
    }

Since if you look at it, the method if it appears in the official source code of X-Road and as it is missing it always causes an error check this file

@egobsv @lucavechi

egobsv commented 3 years ago

You are right, I have added that method. Thanks!