Correct behaivor for class and style override?

egoist / svg-to-vue-component

Transform SVG files into Vue SFC (with hot reloading and SVGO support)

MIT License

235 stars 18 forks source link

Correct behaivor for class and style override? #6

Closed egoist closed 5 years ago

egoist commented 6 years ago

Currently when you set style or class attribute on the imported svg component, it will override the existing ones on the original svg element via Object.assign, will merge be better than assign for such attributes?

andrevandal commented 5 years ago

Hi, I think we should provide these two options.

style=""
class=""
style-override=""
class-override=""

And set -override options to override class and style props too.

What do you think?

egoist commented 5 years ago

Now they're merged, just like a regular Vue component.