search

eishay / jvm-serializers

Benchmark comparing serialization libraries on the JVM
http://groups.google.com/group/java-serialization-benchmarking
3.28k stars 560 forks source link

Doesn't work on Java 8 #46

Closed Stexxen closed 8 years ago

Stexxen commented 9 years ago

Unfortunately it doesn't compile under java 8. First problem was the Scala version (2.8) is incompatible. I upgraded the support compiler to 2.11 but that doesn't work at all, as some required annotations have been removed (@serialization) 2.10 seems to get further ( The annotations are present, but deprecated) but I then blows up at another error

error: bad symbolic reference. A signature in Generic.class refers to type Collection
in package scala.package which is not available.
It may be completely missing from the current classpath, or the version on
the classpath might be incompatible with the version used when compiling Generic.class.
davidB commented 9 years ago

Hi,

I'm the original contributor for scala/sbinary (several years ago). Sbinary is no longer use is scala env. IMHO, scala should be simply remove from the bench.

cakoose commented 9 years ago

Just as an FYI, I'm sorta looking into this now.

Also, is anybody an SBT expert? I think switching to SBT as a build tool might improve a few things. Unfortunately, the build is pretty complicated (since it involves codegen) and I don't think I have the SBT knowledge to do it myself.

On Wed, Oct 1, 2014 at 4:41 AM, David Bernard notifications@github.com wrote:

Hi,

I'm the original contributor for scala/sbinary (several years ago). Sbinary is no longer use is scala env. IMHO, scala should be simply remove from the bench.

— Reply to this email directly or view it on GitHub https://github.com/eishay/jvm-serializers/issues/46#issuecomment-57434836 .

cakoose commented 9 years ago

Ok, I upgraded to Scala 2.11.2. Hopefully that works under Java 8, but I haven't tried.

I filed a bug against scala-pickling. When they fix it, I'll try adding it to the benchmark.

On Wed, Oct 1, 2014 at 7:23 PM, Kannan Goundan kannan@cakoose.com wrote:

Just as an FYI, I'm sorta looking into this now.

  • Upgrading to Scala 2.11.2 (though there's a bug in the way it handles Java files that I'm trying to work around)
  • Removing sbinary
  • Adding scala-pickling (though there's a bug in the way it's macro references classes that I'm trying to fix).

Also, is anybody an SBT expert? I think switching to SBT as a build tool might improve a few things. Unfortunately, the build is pretty complicated (since it involves codegen) and I don't think I have the SBT knowledge to do it myself.

On Wed, Oct 1, 2014 at 4:41 AM, David Bernard notifications@github.com wrote:

Hi,

I'm the original contributor for scala/sbinary (several years ago). Sbinary is no longer use is scala env. IMHO, scala should be simply remove from the bench.

— Reply to this email directly or view it on GitHub https://github.com/eishay/jvm-serializers/issues/46#issuecomment-57434836 .

pascaldekloe commented 8 years ago

Works with Java 8 now.