search

eivindveg / HotSUploader

JavaFX-based Replay Uploader for Heroes of the Storm
Apache License 2.0
185 stars 36 forks source link

Sort accounts by max last modified timestamp, resolves #118 #124

Closed rogusdev closed 8 years ago

eivindveg commented 8 years ago

This is a simple, yet seemingly effective way to deal with this. I'll review this after my vacation. The plan is to allow users to set a default, but this will be a great deference for no set default. Thanks!

eivindveg commented 8 years ago

One note on your stream usages: I prefer a line break on every new segment of the stream. This produces a large amount of lines, but makes it very easy to see what happens.

rogusdev commented 8 years ago

Could you comment on the exact lines you wish to be new line separated? Thanks.

eivindveg commented 8 years ago

The stream formatting I prefer is

list.stream()
   .map(item -> item.toObject())
   .collect(someCollector());

Ie one stream transformation per line. Sorry for bad examples. Currently roaming on my cell phone.

Edit: also, use method reference when available for your transformations

rogusdev commented 8 years ago

I pushed a commit earlier today that I believe should cover that to your tastes then.

eivindveg commented 8 years ago

Thank you for your contribution! This will be in for version 2.1! =)

rogusdev commented 8 years ago

Looking forward to it, glad to help!