BUG: fix deprecation warning in Python 3.12 (pipes is deprecated)

ekalinin / nodeenv

Virtual environment for Node.js & integrator with virtualenv

http://ekalinin.github.io/nodeenv/

Other

1.69k stars 204 forks source link

BUG: fix deprecation warning in Python 3.12 (pipes is deprecated) #344

Closed neutrinoceros closed 8 months ago

neutrinoceros commented 8 months ago

closes #341

In recent versions of Python, pipes.quote is an alias for shlex.quote, but that function is only available from Python 3.3. This patch should work transparently in all supported versions of Python and avoid deprecation warnings in all cases.

neutrinoceros commented 8 months ago

Oh, I'm only seeing now that #342 already fixes it, with the difference that #342 uses try/except and my patch relies on if/else. I'm happy to drop my PR in favour of @musicinmybrain's