search

eko / FeedBundle

A Symfony bundle to build RSS feeds from your entities
http://vincent.composieux.fr
MIT License
141 stars 49 forks source link

Add missing command.xml and remove unused packages #79

Closed franmomu closed 4 years ago

franmomu commented 4 years ago
Q A
Branch? "master"
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://github.com/eko/FeedBundle/issues/77, https://github.com/eko/FeedBundle/issues/78
License MIT
Doc PR reference to the documentation PR, if any

I missed to upload the command.xml file 🤦‍♂️ in https://github.com/eko/FeedBundle/pull/76

EDIT:

I've also removed laminas/laminas-servicemanager that was added in https://github.com/eko/FeedBundle/issues/20 long time ago and I guess that was fixed. I haven't seen any reference in the code to Laminas\ServiceManager or Zend\ServiceManager. And laminas/laminas-http that was added in https://github.com/eko/FeedBundle/commit/2264161b33a0fe19c65e3b75b24a719e8a11f8ef, but I haven't seen any reference either.

franmomu commented 4 years ago

Friendly ping @eko if you could take a look at this.

eko commented 4 years ago

All good to me, thank you for your contribution

franmomu commented 4 years ago

Thank you for the quick reply!