search

el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.
GNU General Public License v3.0
2.74k stars 97 forks source link

[1.12.0b] Significant memory use #40

Closed deviantintegral closed 7 years ago

deviantintegral commented 7 years ago

I'm seeing pretty significant memory use with the extension enabled. For example, this morning I opened Safari, disabled ublock in each tab via the toolbar, and left it idle, with:

I then used Chrome for the rest of the day.

Eight hours later (say 1.5 hours of real use), "Safari Networking" is using 2.5GB of memory. Other times, I've seen the gmail tab go into 2+ GB, but I /think/ that's only when the extension is actively filtering.

Your filter lists

Complete defaults - haven't touched or customized a thing yet.

Anyways, glad to provide some memory profiles, though I'm not too familiar with JS memory profiling (or Safari extension debugging), so I might need some hand holding.

gorhill commented 7 years ago

Did you try the exact same scenario without uBlock installed at all?

deviantintegral commented 7 years ago

Yes, I did try it with the extension disabled.

I'm in the process of trying again with just the Gmail tab. It took longer, but over 2 days it started at ~275MB and now is at 570MB, with uBlock installed but whitelisted. I will double check again and report back after disabling.

ghost commented 7 years ago

I have had significant memory leaks (in excess of 30gb; nearly all of it compressed, the computer still somehow functioned well,) unrelated to uBlock a couple times over the years.

I found that a simple clean out of the cache and cookies, and history, solved the issue. Be sure to backup your personal uBlock rules.

ghost commented 7 years ago

I forgot to mention, a simple manual clean out of the cache, cookies and history. It's more or less a hard reset of the whole browser. You'll need to research the folders location, I cannot remember.

deviantintegral commented 7 years ago

Thanks, annoying that Reset Safari isn't comprehensive enough.

It's been another two days, and with the uBlock extension disabled, the single GMail tab is now at 470MB. Not as much as I saw with the extension enabled, but enough to indicate it might not be uBlock's code leaking. I'll try once more with uBlock enabled, and then do a cache clear to see if that changes anything,

deviantintegral commented 7 years ago

I just spent a few days using Safari actively, but with no extensions at all, and I finally saw leaks in gmail on their own. Thanks for the help, as it does look like this isn't a uBlock issue.