search

el1t / uBlock-Safari

uBlock Origin - An efficient blocker for Chromium, Firefox, and Safari. Fast and lean.
GNU General Public License v3.0
2.74k stars 97 forks source link

Potential fix for #38 #45

Open geoffdutton opened 7 years ago

geoffdutton commented 7 years ago

I noticed when I inspect the global page and run window.location.reload(), it's as though all the tabs lose reference to the background page. So one idea would be to reload each tab as we build out the vAPI.tabs.stack object. Maybe this has something to do with #38?

However, this could be a problem if for some reason it kept restarting, or if it restarted when someone was in the middle of something.

Just an idea.

geoffdutton commented 7 years ago

Instead of reloading the whole tab, we can just make sure they've been added to the tabContexts. Otherwise, it'll return the behind-the-scenes url until the tab is reload.

madeline03 commented 7 years ago

Yes

ruchernchong commented 6 years ago

You might want to rebase and fix the errors.