Devel - Githubissues

elaird / supy

analyze events stored in TTrees in parallel

8 stars 7 forks source link

Devel #144

Closed betchart closed 12 years ago

betchart commented 12 years ago

Hi Ted, Davide,

This is about a month's work of development, quite a few little projects bundled together; I think it is stable and ready to pull into master, so let's review it!

Burt

gerbaudo commented 12 years ago

Hi Burt, Ted,

I was able to test a couple of my analyses with this branch without any problem (also with the new options), so I am OK with this merge.

However, I also tried the new test suite, and I see a couple of failures:

one AssertionError in supy-bin/init.py", line 17
several OverflowError: long int too large to convert coming from the wrappedchain.testLeaves tests

Maybe in ATLAS we're using a python version (2.6.5) different from the one CMS is using?

Thanks,

davide

elaird commented 12 years ago

Hello,

It looks ok to me. I will now merge the pull request.

Ted