search

elaird / supy

analyze events stored in TTrees in parallel
8 stars 7 forks source link

README out of date #84

Open betchart opened 12 years ago

betchart commented 12 years ago

In particular, the quickstart suggests running analyses/example.py, which doesn't exist!

gerbaudo commented 12 years ago

I tried to update the readme, mostly to understand the github 'pull request'. I think I must have done something wrong, because I committed directly to the master, rather than going through a 'pull request'. Here is what I've done: cd supy/ git status git checkout -b fix-readme enw readme.txt git add readme.txt git commit -m 'fix readme' git status git fetch origin master git checkout master git pull origin master git merge fix-readme git push origin I thought that git would not allow me to push directly to the master...did I miss one step? Sorry for the n00b mistake...

gerbaudo commented 12 years ago

Maybe I should have read this page more carefully... https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Fork-and-Pull-Request-workflow I'll be more careful next time, sorry.

betchart commented 12 years ago

Hi Davide,

The usual pattern with a pull request is as follows:

git status (master, clean, up to date with origin) git checkout -b some-project git add some.txt git add file.txt git commit -m "some file, etc" git push origin some-project

then go to github and select the some-project branch, and hit the pull request button.

Burt

On Mon, Mar 19, 2012 at 8:57 PM, Davide Gerbaudo reply@reply.github.com wrote:

I tried to update the readme, mostly to understand the github 'pull request'. I think I must have done something wrong, because I committed directly to the master, rather than going through a 'pull request'. Here is what I've done:  cd supy/  git status  git checkout -b fix-readme  enw readme.txt  git add readme.txt  git commit -m 'fix readme'  git status  git fetch  origin master  git checkout master  git pull origin master  git merge fix-readme  git push origin I thought that git would not allow me to push directly to the master...did I miss one step? Sorry for the n00b mistake...

Reply to this email directly or view it on GitHub: https://github.com/elaird/supy/issues/84#issuecomment-4587214

betchart commented 12 years ago

Its no big deal, and a good learning experience.

On Mon, Mar 19, 2012 at 9:01 PM, Davide Gerbaudo reply@reply.github.com wrote:

Maybe I should have read this page more carefully... https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Fork-and-Pull-Request-workflow I'll be more careful next time, sorry.

Reply to this email directly or view it on GitHub: https://github.com/elaird/supy/issues/84#issuecomment-4587243