search

elastic / apm-agent-dotnet

https://www.elastic.co/guide/en/apm/agent/dotnet/current/index.html
Apache License 2.0
581 stars 207 forks source link

test/increase timeout #2385

Closed reakaleek closed 3 months ago

reakaleek commented 3 months ago
reakaleek commented 3 months ago

@Mpdreamz

While working on https://github.com/elastic/apm-agent-dotnet/pull/2384, I noticed many timeout errors in the azure-tests job when trying to validate the OIDC login.

For testing purposes, I increased the timeout in this PR and triggered the workflow multiple times.

You can see that the azure-tests job succeeded every time.

Mpdreamz commented 3 months ago

Awesome happy to see the delete step finally succeeding again.

It might have been accruing undeleted resources taking longer and longer to delete them all.

reakaleek commented 3 months ago

Awesome happy to see the delete step finally succeeding again.

It might have been accruing undeleted resources taking longer and longer to delete them all.

Cool.

I will add the change to https://github.com/elastic/apm-agent-dotnet/pull/2384 and remove the hardcoded if: ${{ false }} statement.