elastic / apm

Elastic Application Performance Monitoring - resources and general issue tracking for Elastic APM.
https://www.elastic.co/apm
Apache License 2.0
384 stars 114 forks source link

Remove context.db from S3 spans: S3 isn't a database #696

Open trentm opened 2 years ago

trentm commented 2 years ago

Description

context.db.* was added to the spec for AWS S3 spans by accident. As of spec change https://github.com/elastic/apm/pull/683 any S3 spans created by APM agent instrumentation should not set span.context.db.*.

(My read of the Go and Python APM agent implementations was that they already do not set context.db.* for S3 spans, so I didn't create implementation PRs for them.)

Agent Issues