search

elastic / beats-dashboards

DEPRECATED. Moved to https://github.com/elastic/beats. Please use the new repository to add new issues.
Other
196 stars 72 forks source link

Fixed commas #113

Closed ryanmaclean closed 8 years ago

monicasarbu commented 8 years ago

@dedemorton can you please have a look at this PR? Thanks!

dedemorton commented 8 years ago

@ryanmaclean Thanks for your fix. Can you roll back the changes and update the PR? The changes that I haven't marked look OK, but the other changes are not consistent with Elastic style.

ryanmaclean commented 8 years ago

Definitely more pausing than I'm used to, but I can see where you're going with this. The comma after "Then," matches the "Finally," at the end of the doc.

Generally I avoid them in small phrases, but if your style is to break them up, I get that too :)

Will close the PR for now - I think there's only one change to make?

dedemorton commented 8 years ago

@ryanmaclean The Chicago Manual of Style is a good resource to consult if you have questions about specific rules.