search

elastic / beats-tester

E2E tests for the Beats
18 stars 22 forks source link

Add support for testing -oss packages #79

Closed andrewkroh closed 6 years ago

andrewkroh commented 6 years ago

This allows for testing of packages that have -oss suffixes. Executing make run will execute both the run-elastic and run-oss targets (run-oss is commented out until the -oss packages are released).

ph commented 6 years ago

It feels like a typo, the when clause is a jinja2 expression and this is a strict string comparison.

On Thu, Mar 22, 2018 at 11:04 AM, Nicolas Ruflin notifications@github.com wrote:

@ruflin approved this pull request.

I didn't test it locally. Code LGTM.

In roles/test-linux-binary/tasks/main.yml https://github.com/elastic/beats-tester/pull/79#discussion_r176452942:

@@ -60,7 +60,7 @@ wait_for: > path={{workdir}}/output/heartbeat timeout=5 search_regex='"scheme":"http"'

  • when: beat_name == "heartbeat`"
  • when: beat_name == "heartbeat"

What did the tick here do?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/elastic/beats-tester/pull/79#pullrequestreview-106157524, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACgJ3t5E1K5X6SkVesTqg27jJkVaLQks5tg716gaJpZM4S16LC .

--

ph Software Engineer