elastic / elasticsearch-rails

Elasticsearch integrations for ActiveModel/Record and Ruby on Rails
Apache License 2.0
3.07k stars 797 forks source link

8.x support #1035

Closed leifcr closed 6 months ago

leifcr commented 2 years ago

Any plans for 8.x support? I see there is PR #1025, which should solve it?

lexpank commented 2 years ago

Any update on this one?

tsrivishnu commented 2 years ago

Also waiting for an update on this.

picandocodigo commented 2 years ago

We'll eventually update the gem and publish a new release for 8.x, but we can't commit to a date at the moment.

emptyflask commented 2 years ago

So then is there currently any way to use elasticsearch-rails on an app that also has faraday '~> 2.0'? It looks like only elasticsearch-transport '>= 8.1' supports a modern Faraday version, but it's incompatible with the latest elasticsearch-rails.

Frustrating, since ES 8.0 has been out for > 8 months, and this is commercial software...

technige commented 2 years ago

Hi @emptyflask. I'm sorry that we're not able to provide a timescale for an 8.x release at this time, and I do appreciate how frustrating this must be for you. Unlike the clients, which are our primary focus, we're only able to keep this project updated on a best-effort basis right now.

If you wish to discuss this in more detail for your specific case, please contact your support channel.

jaredbeck commented 1 year ago

This is the last blocker in my app preventing our upgrade to Faraday 2.

elasticsearch-persistence -> elasticsearch 7 -> elasticsearch-transport 7 -> faraday 1

Looking forward to a release, thanks for your work.

xjunior commented 1 year ago

It looks like the latest elasticsearch-model 7.x library (7.12.1 right now), along with the rest of the 7 suite (elasticsearch-rails, elasticsearch-ruby) work well with elasticsearch 8 (on my limited test scope). Are there concerns for this setup?

dani-sc commented 1 year ago

Hi @technige ,

even if there is no date when we can expect 8.x support - is it planned after all, or is it advised to stop relying on this gem altogether? It is currently blocking our update to 8.*, as we rely heavily on it.

siba2893 commented 1 year ago

Hey I'm also having issues with faraday as the WhatsApp ruby ask ten uses faraday 2.3 and this one is stuck with faraday 1.7. How can we resolve this issue?

emptyflask commented 1 year ago

It's not ideal if you already have things built around this gem, but searchkick doesn't have this issue, and provides some nice features out of the box like reindexing without downtime. I've migrated some of our projects from elasticsearch-rails to searchkick and it's worked well so far.

gael-ian commented 1 year ago

Is there a list of what have to be done before any elasticsearch 8.x compatible release? If we know what's expected, maybe some of us can help.

xjunior commented 1 year ago

I seriously do not understand how we're getting to version 8.6 of ES and all other languages except Ruby already support it. This issue specifically is 10m/o and we don't even get an answer about what's going on or how we can help.

bbenno commented 1 year ago

Probably off-topic, but also due to this issue being still open, I decided to turn my back on ES and migrated to Meilisearch, whose Rails gem also offers a nicer interface, IMHO.

jeffkirk1 commented 1 year ago

FYI, the elasticsearch-ruby gem IS compatible with 8.6, but the elasticsearch-rails gem is not.

https://github.com/elastic/elasticsearch-ruby

That said, I agree, a ten-month delay in getting elasticsearch-rails up to snuff is not acceptable. Either Elastic should light this candle or decide to stop supporting Rails. Which would be a terrible mistake.

xjunior commented 1 year ago

@jeffkirk1 yep, you're right. Also, this gem DOES work with an ES 8.6 backend, but it's awkward to do so. Also, by using elasticsearch-rails v7, we cannot update elasticsearch-ruby to 8.

Please, Elastic, let's get this done. All the people above are also willing to help if we're told what it takes.

23tux commented 1 year ago

We have the same issue here, the missing v8 support is blocking us from upgrading.

dbourget commented 1 year ago

One more vote for an upgrade to support faraday 2.x.

arjan0307 commented 1 year ago

Will this at least be done before ES 7 is EOL?

zaru commented 1 year ago

A branch supporting v8 has been created. https://github.com/elastic/elasticsearch-rails/commits/8.x

arjan0307 commented 1 year ago

A branch supporting v8 has been created. https://github.com/elastic/elasticsearch-rails/commits/8.x

Is this branch already usable, or is it still in alpha / beta?

picandocodigo commented 1 year ago

The 8.x branch is work in progress. There are still some failing tests in elasticsearch-model that need to be fixed and some further testing and updates before I can publish an official release. But feel free to test it and report any issues. Just be aware that this is code in development and not an official release yet.

NielsKSchjoedt commented 1 year ago

Any update on this? Expected release ETA?

jaredbeck commented 9 months ago

My team can't wait any longer for this issue, and will no longer be able to use this gem. Fortunately, our app only uses Elasticsearch::Persistence::Repository, and we were able to write a limited replacement (search, save, and delete only) using only the lower-level elasticsearch gem. If it would help someone else, I'd be happy to share a redacted gist of some of that work.

neoxader commented 8 months ago

Seems last commits on 8.x update are from September 2023.

When can we expect release

jashkothari commented 6 months ago

Any updates on when 8.x update will be released?

pbourdet commented 6 months ago

Hello, any news of this ? When can we expect the release ?

blackjid commented 6 months ago

@picandocodigo what do you think the timeframe for this would be?

picandocodigo commented 6 months ago

I appreciate this is frustrating, but I can't provide a timeframe just now. This is still a project on a best-effort basis. It would really help if folks interested tested the 8.x branch and reported any issues or opened Pull Requests for fixes to that branch to get it closer to a release.

picandocodigo commented 6 months ago

Elasticsearch Rails 8.0.0.pre is now available. Please let us know of any issues. Thanks to everyone who's contributed to 8.x.