Try to finish remote sink once

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine

https://www.elastic.co/products/elasticsearch

Other

1.49k stars 24.89k forks source link

Try to finish remote sink once #117592

Closed dnhatn closed 3 days ago

dnhatn commented 4 days ago

Currently, we have three clients fetching pages by default, each with its own lifecycle. This can result in scenarios where more than one request is sent to complete the remote sink. While this does not cause correctness issues, it is inefficient, especially for cross-cluster requests. This change tracks the status of the remote sink and tries to send only one finish request per remote sink.

elasticsearchmachine commented 3 days ago

Pinging @elastic/es-analytical-engine (Team:Analytics)

dnhatn commented 3 days ago

Thanks @smalyshev.

elasticsearchmachine commented 3 days ago

💔 Backport failed

Status	Branch	Result
❌	8.17	Commit could not be cherrypicked due to conflicts
✅	8.x

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 117592